Fix types in template package#3461
Merged
Merged
Conversation
sophiajt
reviewed
Jun 5, 2019
Member
Author
|
I disabled generation of untrimmed files for other packages as well. |
The path to the type declaration file is incorrect. This change introduces - rollup of d.ts files using api-extractor - point `types` to the rolled-up azure-template.d.ts file - also generate beta trimmed and public trimmed d.ts rollup files in case we want to publish them (which requires either updating the `types` field in package.json, or overwriting that file) - commit the api report (./review/template.api.md) which is often used to review api changes.
Pack the public trimmed rollup .d.ts instead.
jeremymeng
force-pushed
the
template-declaration-rollup
branch
from
59f3f52 to
ca7ec49
Compare
bterlson
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path to the type declaration file is incorrect. This change introduces
rollup of d.ts files using api-extractor
point
typesto the rolled-up azure-template.d.ts filealso generate beta trimmed and public trimmed d.ts rollup files in case
we want to publish them (which requires either updating the
typesfield inpackage.json, or overwriting that file)
commit the api report (./review/template.api.md) which is often used to review
api changes.